[FFmpeg-cvslog] r25258 - trunk/libavcodec/libvorbis.c

[Diego Biurrun]

On Wed, Sep 29, 2010 at 07:18:33PM +0200, Michael Niedermayer wrote:
> On Wed, Sep 29, 2010 at 06:05:47PM +0200, Stefano Sabatini wrote:
> > On date Wednesday 2010-09-29 17:09:39 +0200, michael wrote:
> > > 
> > > Log:
> > > Allow setting the impulse block bias for libvorbis through a private codec parameter.
> > > First example and test of private codec parameters.
> > > 
> > > --- trunk/libavcodec/libvorbis.c	Wed Sep 29 17:05:47 2010	(r25257)
> > > +++ trunk/libavcodec/libvorbis.c	Wed Sep 29 17:09:38 2010	(r25258)
> > > @@ -82,6 +92,10 @@ static av_cold int oggvorbis_init_encode
> > >  
> > > +    if(context->iblock){
> > > +        vorbis_encode_ctl(vi, OV_ECTL_IBLOCK_SET, &context->iblock);
> > > +    }
> > 
> > Please avoid if(...){ in favor of if_(...)_{ for karma bonus.
> 
> i have better things to do than learning and applying indent -kr to the last
> whitespace

I disagree that this qualifies as a minor part of K&R.  I also think it
would only require a small effort on your part to try to get used to
writing code in K&R style and once you have done that, it will be
completely natural.

So I would like to politely suggest that you try to place a space after
keywords, i.e. after if/for/while/switch/do and between ')' and '{'.

if (...) {
for (...) {
while (...) {
switch (...) {

Everybody else is now using this style, in the long run FFmpeg would
benefit from being written in a more consistent style.

Thanks, Diego