[FFmpeg-cvslog] r25385 - trunk/libavformat/mpegenc.c

[Michael Niedermayer]

On Wed, Oct 06, 2010 at 08:16:20PM -0700, Alex Converse wrote:
> On Wed, Oct 6, 2010 at 6:57 PM, michael <subversion at mplayerhq.hu> wrote:
> >
> > Author: michael
> > Date: Thu Oct ?7 03:57:39 2010
> > New Revision: 25385
> >
> > Log:
> > Warn if muxing mpeg ps is attempted without a VBV buffer size.
> >
> > Modified:
> > ? trunk/libavformat/mpegenc.c
> >
> > Modified: trunk/libavformat/mpegenc.c
> > ==============================================================================
> > --- trunk/libavformat/mpegenc.c Thu Oct ?7 03:57:35 2010 ? ? ? ?(r25384)
> > +++ trunk/libavformat/mpegenc.c Thu Oct ?7 03:57:39 2010 ? ? ? ?(r25385)
> > @@ -367,8 +367,10 @@ static int mpeg_mux_init(AVFormatContext
> > ? ? ? ? ? ? stream->id = mpv_id++;
> > ? ? ? ? ? ? if (st->codec->rc_buffer_size)
> > ? ? ? ? ? ? ? ? stream->max_buffer_size = 6*1024 + st->codec->rc_buffer_size/8;
> > - ? ? ? ? ? ?else
> > + ? ? ? ? ? ?else{
> 
> Just two days ago people asked you to put whitespace after keywords.

yes and iam not doing it, you should vote on me being leader accordingly.

also IMHO, the one who said it loud enough for me to remember it at all is
diego (on the phone ;) ) and he
neither maintains C code nor is he contributing C code. And this is stuff
that should be decided by the people falling in these 2 categories

IMHO such whitespace cosmetics go too far and ive never asked others to
follow such nitpickery. Especially not if they feel strongly about it

Its important that people have fun contributing to the project and to me
this is not fun. Do people want to string up the leader (or for the matter of
fact anyone) in rules that make it not fun for him to work?
This feels backward to me, but maybe its just me.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20101007/fbc40c85/attachment.pgp>