[FFmpeg-cvslog] r25385 - trunk/libavformat/mpegenc.c

Alex Converse alex.converse
Fri Oct 8 18:16:48 CEST 2010


On Fri, Oct 8, 2010 at 8:45 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Thu, Oct 07, 2010 at 09:22:38PM -0700, Alex Converse wrote:
>> On Thursday, October 7, 2010, Michael Niedermayer <michaelni at gmx.at> wrote:
>> > On Wed, Oct 06, 2010 at 08:16:20PM -0700, Alex Converse wrote:
>> >> On Wed, Oct 6, 2010 at 6:57 PM, michael <subversion at mplayerhq.hu> wrote:
>> >> >
>> >> > Author: michael
>> >> > Date: Thu Oct ?7 03:57:39 2010
>> >> > New Revision: 25385
>> >> >
>> >> > Log:
>> >> > Warn if muxing mpeg ps is attempted without a VBV buffer size.
>> >> >
>> >> > Modified:
>> >> > ? trunk/libavformat/mpegenc.c
>> >> >
>> >> > Modified: trunk/libavformat/mpegenc.c
>> >> > ==============================================================================
>> >> > --- trunk/libavformat/mpegenc.c Thu Oct ?7 03:57:35 2010 ? ? ? ?(r25384)
>> >> > +++ trunk/libavformat/mpegenc.c Thu Oct ?7 03:57:39 2010 ? ? ? ?(r25385)
>> >> > @@ -367,8 +367,10 @@ static int mpeg_mux_init(AVFormatContext
>> >> > ? ? ? ? ? ? stream->id = mpv_id++;
>> >> > ? ? ? ? ? ? if (st->codec->rc_buffer_size)
>> >> > ? ? ? ? ? ? ? ? stream->max_buffer_size = 6*1024 + st->codec->rc_buffer_size/8;
>> >> > - ? ? ? ? ? ?else
>> >> > + ? ? ? ? ? ?else{
>> >>
>> >> Just two days ago people asked you to put whitespace after keywords.
>> >
>> > yes and iam not doing it, you should vote on me being leader accordingly.
>> >
>>
>> If there were time left on the vote I absolutely would change my choice to B
>
> time shall not prevent you or anyone else from making such change.
> if you consider a space between else and { important enough ...
>

>> > yes and iam not doing it, you should vote on me being leader accordingly.

The reason is not the space but the attitude that the rules and
conventions don't apply to you.

Regards,
Alex Converse



More information about the ffmpeg-cvslog mailing list