[FFmpeg-cvslog] r25404 - trunk/libavformat/rtpdec.c

[Martin Storsjö]

On Fri, 8 Oct 2010, Ronald S. Bultje wrote:

> On Fri, Oct 8, 2010 at 4:40 AM, mstorsjo <subversion at mplayerhq.hu> wrote:
> > Author: mstorsjo
> > Date: Fri Oct ?8 10:40:08 2010
> > New Revision: 25404
> >
> > Log:
> > rtpdec: Set prev_ret properly when parsing more data from mpegts RTP packets
> 
> I'm not a big fan of this, I'm quit sure most of these aren't strictly
> needed. Can't prev_ret be a cache variable only for the one case where
> prev_ret and the actual return value are different, as originally
> intended, and the rest be handled regardless of its value? We didn't
> need to store the last return value previously either, and it worked
> fine...

I tried to avoid having to do this at many places in the code by wrapping 
all of this in an outer function, see the thread "[PATCH] rtpdec: Better 
logic for immediately returning packets from the queue" on ffmpeg-devel.

// Martin