[FFmpeg-cvslog] r25128 - in trunk: configure libavcodec/libmp3lame.c

[Måns Rullgård]

Carl Eugen Hoyos <cehoyos at ag.or.at> writes:

> M?ns,
>
> M?ns Rullg?rd <mans <at> mansr.com> writes:
>
>> > -        lame_set_VBR_q(s->gfp, avctx->global_quality / (float)FF_QP2LAMBDA);
>> > +        /* requires lame 3.98 or later */
>> > +        lame_set_VBR_quality(s->gfp,
> avctx->global_quality/(float)FF_QP2LAMBDA);
>> 
>> Why did you include that useless comment?  Imagine what it would look
>> like if every function call had a comment like that beside it.
>
> I don't disagree, but please just remove the line instead of ranting.

The latest patch in the thread had it removed.  You must have put it
back.  Now please clean it up.

-- 
M?ns Rullg?rd
mans at mansr.com