[FFmpeg-cvslog] r25185 - in trunk: Changelog doc/filters.texi libavfilter/avfilter.h libavfilter/vf_crop.c tests/lavfi-regression.sh

Måns Rullgård mans
Sat Sep 25 15:32:15 CEST 2010


Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:

> On date Saturday 2010-09-25 14:37:02 +0200, Michael Niedermayer wrote:
>> On Sat, Sep 25, 2010 at 11:36:49AM +0100, M?ns Rullg?rd wrote:
>> > stefano <subversion at mplayerhq.hu> writes:
>> > 
>> > > +enum var_name {
>> > > +    E,
>> > > +    PHI,
>> > > +    PI,
>> > 
>> > This fails on DOS.  Presumably something is defining PI as number.
>> 
>> id suggest to prefix all the enum values by something
>> maybe ID_ oer ENUM, that would also distibguish them stronger from
>> scalar value constants
>
> I'd prefer VAR_, is that OK?

Fine with me.  It's local to that file, so the name is not that important.

-- 
M?ns Rullg?rd
mans at mansr.com



More information about the ffmpeg-cvslog mailing list