[FFmpeg-cvslog] binkaudio: remove unnecessary loop

Peter Ross git
Sat Feb 26 04:51:54 CET 2011


ffmpeg | branch: master | Peter Ross <pross at xvid.org> | Sun Feb 20 12:24:38 2011 +1100| [408ee5a90c4accae5f2dd522c8868a7a2056fa9a] | committer: Michael Niedermayer

binkaudio: remove unnecessary loop

decode_init sets bands[0] == 2, so this loop always sets the band table
index (k) to zero.

Signed-off-by: Ronald S. Bultje <rsbultje at gmail.com>
(cherry picked from commit a304def1dca50d63bf2a39651f84792980db3508)

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=408ee5a90c4accae5f2dd522c8868a7a2056fa9a
---

 libavcodec/binkaudio.c |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/libavcodec/binkaudio.c b/libavcodec/binkaudio.c
index fb442c0..b601a01 100644
--- a/libavcodec/binkaudio.c
+++ b/libavcodec/binkaudio.c
@@ -164,7 +164,6 @@ static void decode_block(BinkAudioContext *s, short *out, int use_dct)
 
     for (ch = 0; ch < s->channels; ch++) {
         FFTSample *coeffs = s->coeffs_ptr[ch];
-        q = 0.0f;
         coeffs[0] = get_float(gb) * s->root;
         coeffs[1] = get_float(gb) * s->root;
 
@@ -174,10 +173,8 @@ static void decode_block(BinkAudioContext *s, short *out, int use_dct)
             quant[i] = expf(FFMIN(value, 95) * 0.15289164787221953823f) * s->root;
         }
 
-        // find band (k)
-        for (k = 0; s->bands[k] < 1; k++) {
-            q = quant[k];
-        }
+        k = 0;
+        q = quant[0];
 
         // parse coefficients
         i = 2;




More information about the ffmpeg-cvslog mailing list