[FFmpeg-cvslog] Revert "ac3enc: use MUL64() to multiply fixed-point coefficients"

Michael Niedermayer git
Fri Mar 11 15:36:29 CET 2011


ffmpeg | branch: master | Michael Niedermayer <michaelni at gmx.at> | Wed Mar  9 19:50:36 2011 +0100| [2800e8d62e4c6cdd8a7e218cb15a10f216946f18] | committer: Michael Niedermayer

Revert "ac3enc: use MUL64() to multiply fixed-point coefficients"

Author says, this is unneeded.

This reverts commit 67fc32ac6197a7fe265795d0bf60bf704464394e.

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=2800e8d62e4c6cdd8a7e218cb15a10f216946f18
---

 libavcodec/ac3enc.c       |    8 ++++----
 libavcodec/ac3enc_fixed.h |    2 --
 libavcodec/ac3enc_float.h |    2 --
 3 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/libavcodec/ac3enc.c b/libavcodec/ac3enc.c
index 4fc8106..863f200 100644
--- a/libavcodec/ac3enc.c
+++ b/libavcodec/ac3enc.c
@@ -328,10 +328,10 @@ static void compute_rematrixing_strategy(AC3EncodeContext *s)
                 CoefType rt = block->mdct_coef[1][i];
                 CoefType md = lt + rt;
                 CoefType sd = lt - rt;
-                sum[0] += MUL_COEF(lt, lt);
-                sum[1] += MUL_COEF(rt, rt);
-                sum[2] += MUL_COEF(md, md);
-                sum[3] += MUL_COEF(sd, sd);
+                sum[0] += lt * lt;
+                sum[1] += rt * rt;
+                sum[2] += md * md;
+                sum[3] += sd * sd;
             }
 
             /* compare sums to determine if rematrixing will be used for this band */
diff --git a/libavcodec/ac3enc_fixed.h b/libavcodec/ac3enc_fixed.h
index 773caec..12c8ace 100644
--- a/libavcodec/ac3enc_fixed.h
+++ b/libavcodec/ac3enc_fixed.h
@@ -36,8 +36,6 @@ typedef int16_t SampleType;
 typedef int32_t CoefType;
 typedef int64_t CoefSumType;
 
-#define MUL_COEF(a,b) MUL64(a,b)
-
 
 /**
  * Compex number.
diff --git a/libavcodec/ac3enc_float.h b/libavcodec/ac3enc_float.h
index 6ad22ec..1726ca0 100644
--- a/libavcodec/ac3enc_float.h
+++ b/libavcodec/ac3enc_float.h
@@ -36,8 +36,6 @@ typedef float SampleType;
 typedef float CoefType;
 typedef float CoefSumType;
 
-#define MUL_COEF(a,b) ((a)*(b))
-
 
 typedef struct AC3MDCTContext {
     const float *window;    ///< MDCT window function




More information about the ffmpeg-cvslog mailing list