[FFmpeg-cvslog] Fix incorrect colors when decoding DVD subtitles

Alexandre Colucci git at videolan.org
Fri Mar 25 19:03:12 CET 2011


ffmpeg | branch: master | Alexandre Colucci <alexandre at elgato.com> | Fri Mar 25 11:25:02 2011 +0100| [9743e909f113b2f7b09e4879871e3b8e66d32204] | committer: Michael Niedermayer

Fix incorrect colors when decoding DVD subtitles

On DVD and HD-DVD colors are stored in the order YCrCb (and not YCbCr) as mentioned in the specifications:
see DVD Specifications for Read-Only Disc / Part 3, 4.3 Program Chain Information (7) PGC_SP_PLT
see DVD Specifications for High Definition Disc, 5.2 Navigation for Standard Content (11) PGC_SDSP_PLT
see DVD Specifications for High Definition Disc, 5.2 Navigation for Standard Content (12) PGC_HDSP_PLT
see DVD Specifications for High Definition Disc, 5.5 Presentation Data (4) SET_COLOR2

When decoding a DVD or HD-DVD subtitle, the colors were incorrectly set.

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=9743e909f113b2f7b09e4879871e3b8e66d32204
---

 libavcodec/dvdsubdec.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/libavcodec/dvdsubdec.c b/libavcodec/dvdsubdec.c
index bea2646..507c181 100644
--- a/libavcodec/dvdsubdec.c
+++ b/libavcodec/dvdsubdec.c
@@ -34,8 +34,8 @@ static void yuv_a_to_rgba(const uint8_t *ycbcr, const uint8_t *alpha, uint32_t *
 
     for (i = num_values; i > 0; i--) {
         y = *ycbcr++;
-        cb = *ycbcr++;
         cr = *ycbcr++;
+        cb = *ycbcr++;
         YUV_TO_RGB1_CCIR(cb, cr);
         YUV_TO_RGB2_CCIR(r, g, b, y);
         *rgba++ = (*alpha++ << 24) | (r << 16) | (g << 8) | b;




More information about the ffmpeg-cvslog mailing list