[FFmpeg-cvslog] doc: Remind devs to check return values, especially for malloc() et al

Diego Biurrun git at videolan.org
Mon Jul 2 21:24:13 CEST 2012


ffmpeg | branch: master | Diego Biurrun <diego at biurrun.de> | Sat Jun 30 15:35:57 2012 +0200| [4aad316bff610c34b6eb047644e616982bdde621] | committer: Diego Biurrun

doc: Remind devs to check return values, especially for malloc() et al

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=4aad316bff610c34b6eb047644e616982bdde621
---

 doc/developer.texi |    4 ++++
 1 file changed, 4 insertions(+)

diff --git a/doc/developer.texi b/doc/developer.texi
index 2e25f5f..d36f53f 100644
--- a/doc/developer.texi
+++ b/doc/developer.texi
@@ -488,6 +488,10 @@ send a reminder by email. Your patch should eventually be dealt with.
 @item
     Lines with similar content should be aligned vertically when doing so
     improves readability.
+ at item
+    Make sure you check the return values of function and return appropriate
+    error codes. Especially memory allocation functions like @code{malloc()}
+    are notoriously left unchecked, which is a serious problem.
 @end enumerate
 
 @section Patch review process



More information about the ffmpeg-cvslog mailing list