[FFmpeg-cvslog] movenc: Addtion of \251cmt field to udta
Al@dneg.com
git at videolan.org
Mon Jul 9 15:31:23 CEST 2012
ffmpeg | branch: master | Al at dneg.com <Al at dneg.com> | Mon Jul 9 10:40:12 2012 +0100| [c88a832735e3ea3eb30d5df8afbe408ce2e6be43] | committer: Michael Niedermayer
movenc: Addtion of \251cmt field to udta
Allows support of comment in udta for libquicktime, also currently \251des is used
which is ignored by mov.c.
\251cmt IS currently already picked up by mov.c
References
libquicktime
http://libquicktime.cvs.sourceforge.net/viewvc/libquicktime/libquicktime/src/udta.c?view=markup
Also listed here:
http://www.sno.phy.queensu.ca/~phil/exiftool/TagNames/QuickTime.html#UserData
Not listed here, but that`s not entirely surprising, as udta fields are expected to be somewhat arbitary.
http://developer.apple.com/library/mac/#documentation/QuickTime/qtff/QTFFChap2/qtff2.html#//apple_ref/doc/uid/TP40000939-CH204-BBCCFFGD
Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=c88a832735e3ea3eb30d5df8afbe408ce2e6be43
---
libavformat/movenc.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/libavformat/movenc.c b/libavformat/movenc.c
index 89072d5..7ae6c45 100644
--- a/libavformat/movenc.c
+++ b/libavformat/movenc.c
@@ -2078,7 +2078,10 @@ static int mov_write_udta_tag(AVIOContext *pb, MOVMuxContext *mov,
mov_write_string_metadata(s, pb_buf, "\251alb", "album" , 0);
mov_write_string_metadata(s, pb_buf, "\251day", "date" , 0);
mov_write_string_metadata(s, pb_buf, "\251swr", "encoder" , 0);
+ // currently ignored by mov.c
mov_write_string_metadata(s, pb_buf, "\251des", "comment" , 0);
+ // add support for libquicktime, this atom is also actually read by mov.c
+ mov_write_string_metadata(s, pb_buf, "\251cmt", "comment" , 0);
mov_write_string_metadata(s, pb_buf, "\251gen", "genre" , 0);
mov_write_string_metadata(s, pb_buf, "\251cpy", "copyright" , 0);
} else {
More information about the ffmpeg-cvslog
mailing list