[FFmpeg-cvslog] alac: simplify 1st order prediction and reading of warm-up samples

Justin Ruggles git at videolan.org
Thu Jul 19 23:35:52 CEST 2012


ffmpeg | branch: master | Justin Ruggles <justin.ruggles at gmail.com> | Mon Jul  9 11:12:25 2012 -0400| [01880d287be6e2269b92eee8d9dc442532d277ea] | committer: Justin Ruggles

alac: simplify 1st order prediction and reading of warm-up samples

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=01880d287be6e2269b92eee8d9dc442532d277ea
---

 libavcodec/alac.c |   18 +++++-------------
 1 file changed, 5 insertions(+), 13 deletions(-)

diff --git a/libavcodec/alac.c b/libavcodec/alac.c
index 9a3ca51..b19973d 100644
--- a/libavcodec/alac.c
+++ b/libavcodec/alac.c
@@ -186,25 +186,17 @@ static void predictor_decompress_fir_adapt(int32_t *error_buffer,
         /* simple 1st-order prediction */
         if (output_size <= 1)
             return;
-        for (i = 0; i < output_size - 1; i++) {
-            int32_t prev_value;
-            int32_t error_value;
-
-            prev_value = buffer_out[i];
-            error_value = error_buffer[i+1];
-            buffer_out[i+1] =
-                sign_extend((prev_value + error_value), readsamplesize);
+        for (i = 1; i < output_size; i++) {
+            buffer_out[i] = sign_extend(buffer_out[i - 1] + error_buffer[i],
+                                        readsamplesize);
         }
         return;
     }
 
     /* read warm-up samples */
     for (i = 0; i < predictor_coef_num; i++) {
-        int32_t val;
-
-        val = buffer_out[i] + error_buffer[i+1];
-        val = sign_extend(val, readsamplesize);
-        buffer_out[i+1] = val;
+        buffer_out[i + 1] = sign_extend(buffer_out[i] + error_buffer[i + 1],
+                                        readsamplesize);
     }
 
     /* NOTE: 4 and 8 are very common cases that could be optimized. */



More information about the ffmpeg-cvslog mailing list