[FFmpeg-cvslog] Fix linking without yasm.

[Clément Bœsch]

On Sat, Mar 24, 2012 at 10:45:52PM +0000, Carl Eugen Hoyos wrote:
> Clément Bœsch <ubitux <at> gmail.com> writes:
> 
> > > -dsp->put_no_rnd_vc1_chroma_pixels_tab[0]= ff_put_vc1_chroma_mc8_mmx_nornd;
> > > +if (HAVE_YASM)
> > > + dsp->put_no_rnd_vc1_chroma_pixels_tab[0]= ff_put_vc1_chroma_mc8_mmx_nornd;
> > 
> > I may miss something obvious but isn't this abusing the fact the compiler
> > will optimize out this branch? 
> 
> We are using this fact on many places in the code, 
> it is seen as a feature, 
> 
> > Aren't we supposed to use the cpp here?
> 
> because it allows to check for syntax etc. because we do not 
> (only) use cpp.
> 
> (I have no strong opinion on this, but above is what was 
> written many times here afair.)

[...]

On Sat, Mar 24, 2012 at 11:43:36PM +0100, Nicolas George wrote:
> Le quintidi 5 germinal, an CCXX, Clément Bœsch a écrit :
> > I may miss something obvious but isn't this abusing the fact the compiler
> > will optimize out this branch? Aren't we supposed to use the cpp here?
> 
> It's used all over the place. Just look at allcodecs.c for examples.

OK. Thank you both for the explanations :)

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-cvslog/attachments/20120324/79d76a50/attachment.asc>