[FFmpeg-cvslog] sws: revert: "swscale: Remove two bogus asserts"

[Michael Niedermayer]

On Thu, Sep 13, 2012 at 06:59:49PM +0200, Reimar Döffinger wrote:
> On Thu, Sep 13, 2012 at 04:52:06PM +0200, Michael Niedermayer wrote:
> > ffmpeg | branch: master | Michael Niedermayer <michaelni at gmx.at> | Thu Sep 13 15:53:05 2012 +0200| [0ed0f2e56600d8b404c22530a75c11b60a5380a7] | committer: Michael Niedermayer
> > 
> > sws: revert: "swscale: Remove two bogus asserts"
> 
> A bit more text (like explaining what they check) might not hurt,
> I think taking someone misunderstanding the code as a first
> approximation that it should be clarified is usually not a bad idea.
> 
> > +                av_assert1(lumSrcPtr  + vLumFilterSize - 1 < lumPixBuf  + vLumBufSize * 2);
> > +                av_assert1(chrUSrcPtr + vChrFilterSize - 1 < chrUPixBuf + vChrBufSize * 2);
> 
> Why does this use -1 and < instead of just <= ?

it checks if the last access is within the buffer, its more
logic with -1


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 3
"Rare item" - "Common item with rare defect or maybe just a lie"
"Professional" - "'Toy' made in china, not functional except as doorstop"
"Experts will know" - "The seller hopes you are not an expert"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-cvslog/attachments/20120913/cbbe16a4/attachment.asc>