[FFmpeg-cvslog] 8bps: decode 24bit files correctly as rgb32 on bigendian

Janne Grunau git at videolan.org
Fri Aug 16 11:49:48 CEST 2013


ffmpeg | branch: master | Janne Grunau <janne-libav at jannau.net> | Fri Jul 19 13:51:51 2013 +0200| [e8c0defe1322f0ff281d9bc5eee91fa1b712b6aa] | committer: Janne Grunau

8bps: decode 24bit files correctly as rgb32 on bigendian

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=e8c0defe1322f0ff281d9bc5eee91fa1b712b6aa
---

 libavcodec/8bps.c |   18 +++++++-----------
 1 file changed, 7 insertions(+), 11 deletions(-)

diff --git a/libavcodec/8bps.c b/libavcodec/8bps.c
index ad1266f..552e926 100644
--- a/libavcodec/8bps.c
+++ b/libavcodec/8bps.c
@@ -168,17 +168,7 @@ static av_cold int decode_init(AVCodecContext *avctx)
     case 32:
         avctx->pix_fmt = AV_PIX_FMT_RGB32;
         c->planes      = 4;
-#if HAVE_BIGENDIAN
-        c->planemap[0] = 1; // 1st plane is red
-        c->planemap[1] = 2; // 2nd plane is green
-        c->planemap[2] = 3; // 3rd plane is blue
-        c->planemap[3] = 0; // 4th plane is alpha???
-#else
-        c->planemap[0] = 2; // 1st plane is red
-        c->planemap[1] = 1; // 2nd plane is green
-        c->planemap[2] = 0; // 3rd plane is blue
-        c->planemap[3] = 3; // 4th plane is alpha???
-#endif
+        /* handle planemap setup later for decoding rgb24 data as rbg32 */
         break;
     default:
         av_log(avctx, AV_LOG_ERROR, "Error: Unsupported color depth: %u.\n",
@@ -186,6 +176,12 @@ static av_cold int decode_init(AVCodecContext *avctx)
         return AVERROR_INVALIDDATA;
     }
 
+    if (avctx->pix_fmt == AV_PIX_FMT_RGB32) {
+        c->planemap[0] = HAVE_BIGENDIAN ? 1 : 2; // 1st plane is red
+        c->planemap[1] = HAVE_BIGENDIAN ? 2 : 1; // 2nd plane is green
+        c->planemap[2] = HAVE_BIGENDIAN ? 3 : 0; // 3rd plane is blue
+        c->planemap[3] = HAVE_BIGENDIAN ? 0 : 3; // 4th plane is alpha???
+    }
     return 0;
 }
 



More information about the ffmpeg-cvslog mailing list