[FFmpeg-cvslog] x86: h264: Don't use redzone in AVX h264_deblock on Win64

Matt Wolenetz git at videolan.org
Tue Feb 26 03:39:00 CET 2013


ffmpeg | branch: release/1.1 | Matt Wolenetz <wolenetz at chromium.org> | Fri Feb 15 13:59:40 2013 -0800| [bc9d341be84eeae1c0b33295284df4e285e577dc] | committer: Martin Storsjö

x86: h264: Don't use redzone in AVX h264_deblock on Win64

This fixes crashes in chromium on win64 on machines with AVX
(crashes that apparently aren't triggered by fate).

Signed-off-by: Martin Storsjö <martin at martin.st>
(cherry picked from commit 311443f6c7eb230276e320f2d30a5d729cf32b76)

Signed-off-by: Martin Storsjö <martin at martin.st>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=bc9d341be84eeae1c0b33295284df4e285e577dc
---

 libavcodec/x86/h264_deblock.asm |    8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/libavcodec/x86/h264_deblock.asm b/libavcodec/x86/h264_deblock.asm
index 1f1dbc6..67f9c02 100644
--- a/libavcodec/x86/h264_deblock.asm
+++ b/libavcodec/x86/h264_deblock.asm
@@ -621,7 +621,11 @@ DEBLOCK_LUMA v, 16
     %define t5 m11
     %define mask0 m12
     %define mask1p m13
+%if WIN64
+    %define mask1q [rsp]
+%else
     %define mask1q [rsp-24]
+%endif
     %define mpb_0 m14
     %define mpb_1 m15
 %else
@@ -640,7 +644,11 @@ DEBLOCK_LUMA v, 16
 ;-----------------------------------------------------------------------------
 ; void deblock_v_luma_intra( uint8_t *pix, int stride, int alpha, int beta )
 ;-----------------------------------------------------------------------------
+%if WIN64
+cglobal deblock_%1_luma_intra_8, 4,6,16,0x10
+%else
 cglobal deblock_%1_luma_intra_8, 4,6,16,ARCH_X86_64*0x50-0x50
+%endif
     lea     r4, [r1*4]
     lea     r5, [r1*3] ; 3*stride
     dec     r2d        ; alpha-1



More information about the ffmpeg-cvslog mailing list