[FFmpeg-cvslog] libopencore-amr: Fix assignments in if()

[Alexander Strasser]

Hi,

Reimar Döffinger wrote:
> On 14 Jan 2013, at 05:28, git at videolan.org (Michael Niedermayer) wrote:
> > ffmpeg | branch: master | Michael Niedermayer <michaelni at gmx.at> | Mon Jan 14 00:04:13 2013 +0100| [d6180aa29741334cf69f691b27ffceb33f49d36a] | committer: Michael Niedermayer
> > 
> > libopencore-amr: Fix assignments in if()
> 
> I can't help to suggest to take that huge amount of bugs as a hint and stop with this obfuscating coding style of cramming the function call and assignment into the if.
> Just my point of view on this...
  
  +1

  I thought the same when I read those patches initially.

  What I found even more amazing is how easy it is to overlook
those coding mistakes when reading code (even the patch). I am
sure Michael used some grep-like tool to find that many instances.

  Alexander