[FFmpeg-cvslog] id3v2: check for end of file while unescaping tags
Luca Barbato
git at videolan.org
Fri May 3 15:50:14 CEST 2013
ffmpeg | branch: master | Luca Barbato <lu_zero at gentoo.org> | Wed May 1 19:01:11 2013 +0200| [af4cc2605c7a56ecfd84c264aa2b325020418472] | committer: Luca Barbato
id3v2: check for end of file while unescaping tags
Prevent a serious out of buffer bound write.
Reported-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC:libav-stable at libav.org
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=af4cc2605c7a56ecfd84c264aa2b325020418472
---
libavformat/id3v2.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/libavformat/id3v2.c b/libavformat/id3v2.c
index 0563e6b..e5f7486 100644
--- a/libavformat/id3v2.c
+++ b/libavformat/id3v2.c
@@ -644,9 +644,10 @@ static void id3v2_parse(AVFormatContext *s, int len, uint8_t version,
goto seek;
}
b = buffer;
- while (avio_tell(s->pb) < end) {
+ while (avio_tell(s->pb) < end && !s->pb->eof_reached) {
*b++ = avio_r8(s->pb);
- if (*(b - 1) == 0xff && avio_tell(s->pb) < end - 1) {
+ if (*(b - 1) == 0xff && avio_tell(s->pb) < end - 1 &&
+ !s->pb->eof_reached ) {
uint8_t val = avio_r8(s->pb);
*b++ = val ? val : avio_r8(s->pb);
}
More information about the ffmpeg-cvslog
mailing list