[FFmpeg-cvslog] proresdec2: Only try to decode alpha plane if four output planes were allocated.
Reimar Döffinger
Reimar.Doeffinger at gmx.de
Mon May 20 00:31:50 CEST 2013
Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
>Reimar Döffinger <Reimar.Doeffinger <at> gmx.de> writes:
>
>> > proresdec2: Only try to decode alpha plane if four
>> > output planes were allocated.
>> >
>> > Fixes a crash with MPlayer.
>>
>> This seems strange, I don't quite understand how this happens,
>
>Do you mean you cannot reproduce the crash?
I don't have MPlayer at hand right now.
What I am thinking is: either the pixfmt selected is a format with alpha, then it is just plain wrong to give FFmpeg a buffer without an alpha plane allocated, and this check is hiding the real bug.
Or, a format without alpha was selected, then I think the check should be for the pixfmt, because I don't think the FFmpeg API requires unused pointers to be set to NULL by get_buffer.
More information about the ffmpeg-cvslog
mailing list