[FFmpeg-cvslog] configure: Fix ld flags when rpath is enabled.

[Michael Niedermayer]

On Sat, Apr 26, 2014 at 10:07:48PM +0200, Reimar Döffinger wrote:
> On Sat, Apr 26, 2014 at 08:41:27PM +0200, Michael Niedermayer wrote:
> > On Sat, Apr 26, 2014 at 01:05:33PM +0200, Reimar Döffinger wrote:
> > > On Thu, Apr 24, 2014 at 03:46:20AM +0200, YuDenzel wrote:
> > > > ffmpeg | branch: master | YuDenzel <yudenzel at outlook.com> | Wed Apr 23 13:06:37 2014 +0800| [443936d8b9995c1b4edba5f2aa7204e77e5232e7] | committer: Michael Niedermayer
> > > > 
> > > > configure: Fix ld flags when rpath is enabled.
> > > > 
> > > > Provide correct rpath flags to ld when --enable-rpath is provided.
> > > > 
> > > > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=443936d8b9995c1b4edba5f2aa7204e77e5232e7
> > > > ---
> > > > 
> > > >  configure |    2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > diff --git a/configure b/configure
> > > > index ddd0eeb..413cf9a 100755
> > > > --- a/configure
> > > > +++ b/configure
> > > > @@ -4823,7 +4823,7 @@ check_disable_warning -Wno-pointer-sign
> > > >  # add some linker flags
> > > >  check_ldflags -Wl,--warn-common
> > > >  check_ldflags -Wl,-rpath-link=libpostproc:libswresample:libswscale:libavfilter:libavdevice:libavformat:libavcodec:libavutil:libavresample
> > > > -enabled rpath && add_ldflags -Wl,-rpath=$libdir
> > > > +enabled rpath && add_ldflags -Wl,-rpath,$libdir
> > > 
> > > Sorry if I missed the discussion, but my "ld" man pages says the syntax
> > > is
> > > -rpath=dir
> > > not
> > > -rpath dir
> > > which this one will pass to it?
> > 
> > hmm, before i applied i searched with google and the first page i
> > found listed it with space and i failed to find something really
> > authorative
> > also we had another case that uses -rpath, in configure
> > 
> > does someone know which way is better or more correct / wider
> > supported?
> > or has some link to some document about this ?
> 
> I couldn't find anything specific, but my guess from what I could
> find is:
> 1) GNU linker supports "-rpath=path" and only this variant is documented
> 2) "-rpath path" seems to work fine on the GNU linker
> 3) A lot of people use syntax 2), probably because it is supported by
> more linkers, though I could not find a specific example of one
> that does not accept syntax 1).
> 
> Just out of curiosity: do you or anyone else have such an example
> where = does not work?

me, no i dont have one

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

DNS cache poisoning attacks, popular search engine, Google internet authority
dont be evil, please
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-cvslog/attachments/20140427/fb137f0b/attachment.asc>