[FFmpeg-cvslog] ffserver: do not ignore setsockopt return

Reynaldo H. Verdejo Pinochet git at videolan.org
Tue Apr 29 07:12:12 CEST 2014


ffmpeg | branch: master | Reynaldo H. Verdejo Pinochet <r.verdejo at sisa.samsung.com> | Mon Apr 28 11:58:37 2014 -0400| [8baa5b32a59c9426142cd602aff7aacbb4a3bf7c] | committer: Reynaldo H. Verdejo Pinochet

ffserver: do not ignore setsockopt return

Should fix FFmpeg Coverity Scan issue #732181

Signed-off-by: Reynaldo H. Verdejo Pinochet <r.verdejo at sisa.samsung.com>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=8baa5b32a59c9426142cd602aff7aacbb4a3bf7c
---

 ffserver.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/ffserver.c b/ffserver.c
index dd55751..1d32892 100644
--- a/ffserver.c
+++ b/ffserver.c
@@ -556,7 +556,8 @@ static int socket_open_listen(struct sockaddr_in *my_addr)
     }
 
     tmp = 1;
-    setsockopt(server_fd, SOL_SOCKET, SO_REUSEADDR, &tmp, sizeof(tmp));
+    if (setsockopt(server_fd, SOL_SOCKET, SO_REUSEADDR, &tmp, sizeof(tmp)))
+        av_log(NULL, AV_LOG_WARNING, "setsockopt SO_REUSEADDR failed\n");
 
     my_addr->sin_family = AF_INET;
     if (bind (server_fd, (struct sockaddr *) my_addr, sizeof (*my_addr)) < 0) {



More information about the ffmpeg-cvslog mailing list