[FFmpeg-cvslog] pngenc: Drop pointless pointer cast in png_write_row()
Reimar Döffinger
Reimar.Doeffinger at gmx.de
Fri Aug 1 21:17:53 CEST 2014
On Fri, Aug 01, 2014 at 04:28:54PM +0200, Diego Biurrun wrote:
> ffmpeg | branch: master | Diego Biurrun <diego at biurrun.de> | Tue Jul 29 08:43:40 2014 -0700| [5735552f1f17ea01dcbc99b08f54b5bf52176a8f] | committer: Diego Biurrun
>
> pngenc: Drop pointless pointer cast in png_write_row()
>
> > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=5735552f1f17ea01dcbc99b08f54b5bf52176a8f
> ---
>
> libavcodec/pngenc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/pngenc.c b/libavcodec/pngenc.c
> index a349ee8..3d11f37 100644
> --- a/libavcodec/pngenc.c
> +++ b/libavcodec/pngenc.c
> @@ -213,7 +213,7 @@ static int png_write_row(PNGEncContext *s, const uint8_t *data, int size)
> int ret;
>
> s->zstream.avail_in = size;
> - s->zstream.next_in = (uint8_t *)data;
> + s->zstream.next_in = data;
Huh? Did they seriously fix their API???
Either way, next_in used to be non-const, which was the reason for the
cast...
Though I believe we get a warning either way, just a different one, so I
guess you could discuss how much sense the cast had.
More information about the ffmpeg-cvslog
mailing list