[FFmpeg-cvslog] libavcodec/webp: treat out-of-bound palette index as translucent black

Pascal Massimino pascal.massimino at gmail.com
Tue Sep 23 00:06:07 CEST 2014


Reimar,

On Fri, Sep 19, 2014 at 10:14 AM, Reimar Döffinger <Reimar.Doeffinger at gmx.de
> wrote:

> On 19 September 2014 15:36:38 GMT+01:00, git at videolan.org wrote:
> >ffmpeg | branch: master | Pascal Massimino <pascal.massimino at gmail.com>
> >| Tue Sep 16 17:01:07 2014 +0200|
> >[4fd21d58a72c38ab63c3a4483b420db260fa7b8d] | committer: Michael
> >Niedermayer
> >
> >libavcodec/webp: treat out-of-bound palette index as translucent black
> >
> >See https://code.google.com/p/webp/issues/detail?id=206
> >for a description of the problem/fix.
>
> Sorry I got side-tracked and thus missed two specific points about the
> patch itself:
> 1) we should just create larger lookup tables and avoid the if since that
> code seems performance critical
>

sending a patch to do just that (i see a 2-3% faster decoding on ffmpeg for
a big image here).

Also: the patch had a bug! The default color is transparent black, so
0x00000000, and not 0xff000000 like in the patch (my bad).

/skal

2) at least for FF_ER_EXPLODE or so we should keep the check and error out,
> at least as long the official statement is that it will only happen for
> corrupted frames
>
> _______________________________________________
> ffmpeg-cvslog mailing list
> ffmpeg-cvslog at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-cvslog
>


More information about the ffmpeg-cvslog mailing list