[FFmpeg-cvslog] aacenc: mark the "faac"-like coder for removal

Rostislav Pehlivanov git at videolan.org
Sat Dec 5 17:10:22 CET 2015


ffmpeg | branch: master | Rostislav Pehlivanov <atomnuker at gmail.com> | Sat Dec  5 14:38:44 2015 +0000| [3a6e0208615e2f8eddeb58f62b9301bd9b236025] | committer: Rostislav Pehlivanov

aacenc: mark the "faac"-like coder for removal

This coder produces a much lower quality audio than the rest, is much
slower and is unstable. Hasn't been updated for a very long time as
well, hence it is more appropriate to remove it since it also depends on
a big burden of a code (the encode_window_bands_info function which is
just as old, just as unstable and bad and in no way modifiable or
fixable).

Signed-off-by: Rostislav Pehlivanov <atomnuker at gmail.com>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=3a6e0208615e2f8eddeb58f62b9301bd9b236025
---

 libavcodec/aacenc.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/libavcodec/aacenc.c b/libavcodec/aacenc.c
index b370f43..43bb017 100644
--- a/libavcodec/aacenc.c
+++ b/libavcodec/aacenc.c
@@ -967,6 +967,8 @@ static av_cold int aac_encode_init(AVCodecContext *avctx)
     s->coder = &ff_aac_coders[s->options.coder];
 
     if (s->options.coder != AAC_CODER_TWOLOOP) {
+        WARN_IF(s->options.coder == AAC_CODER_FAAC,
+                "The FAAC-like coder will be removed in the near future, please use twoloop!\n");
         s->options.intensity_stereo = 0;
         s->options.pns = 0;
     }



More information about the ffmpeg-cvslog mailing list