[FFmpeg-cvslog] avfilter/internal: add fixme to ff_norm_qscale() to document obvious scaling issue

Michael Niedermayer git at videolan.org
Sat Jan 10 04:03:28 CET 2015


ffmpeg | branch: master | Michael Niedermayer <michaelni at gmx.at> | Sat Jan 10 02:27:49 2015 +0100| [bdb136d302182229f4c383f057d2c9ac565ae39d] | committer: Michael Niedermayer

avfilter/internal: add fixme to ff_norm_qscale() to document obvious scaling issue

Signed-off-by: Michael Niedermayer <michaelni at gmx.at>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=bdb136d302182229f4c383f057d2c9ac565ae39d
---

 libavfilter/internal.h |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/libavfilter/internal.h b/libavfilter/internal.h
index d3a859c..a7ec751 100644
--- a/libavfilter/internal.h
+++ b/libavfilter/internal.h
@@ -377,6 +377,8 @@ void ff_filter_graph_remove_filter(AVFilterGraph *graph, AVFilterContext *filter
 
 /**
  * Normalize the qscale factor
+ * FIXME the H264 qscale is a log based scale, mpeg1/2 is not, the code below
+ *       cannot be optimal
  */
 static inline int ff_norm_qscale(int qscale, int type)
 {



More information about the ffmpeg-cvslog mailing list