[FFmpeg-cvslog] avformat/allformats: Making av_register_all() thread-safe.
Vivekanand
git at videolan.org
Mon Jun 6 00:31:59 CEST 2016
ffmpeg | branch: master | Vivekanand <sendtovivekanand at gmail.com> | Thu Apr 7 16:34:23 2016 +0530| [b092ee701f4d0ef2b8a4171cd38101d1ee9a1034] | committer: Michael Niedermayer
avformat/allformats: Making av_register_all() thread-safe.
When multiple threads tries to call av_register_all(), the first thread sets
initialized to 1 and do the register process. At the same time, other thread might
also call av_register_all(), which returns immediately because initialized is set to 1
(even when it has not completed registering codecs). We can avoid this problem
if we set initialised to 1 while exiting from function.
Github: Closes #196
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=b092ee701f4d0ef2b8a4171cd38101d1ee9a1034
---
libavformat/allformats.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libavformat/allformats.c b/libavformat/allformats.c
index 0a38793..ddf540c 100644
--- a/libavformat/allformats.c
+++ b/libavformat/allformats.c
@@ -47,7 +47,6 @@ void av_register_all(void)
if (initialized)
return;
- initialized = 1;
avcodec_register_all();
@@ -371,4 +370,6 @@ void av_register_all(void)
REGISTER_DEMUXER (LIBGME, libgme);
REGISTER_DEMUXER (LIBMODPLUG, libmodplug);
REGISTER_MUXDEMUX(LIBNUT, libnut);
+
+ initialized = 1;
}
More information about the ffmpeg-cvslog
mailing list