[FFmpeg-cvslog] avcodec/utils: Move avctx->codec check before its use

Michael Niedermayer git at videolan.org
Fri May 20 04:34:53 CEST 2016


ffmpeg | branch: master | Michael Niedermayer <michael at niedermayer.cc> | Fri May 20 04:18:20 2016 +0200| [b24fffeb9476b46be89229c8df338a8c8f1a9a62] | committer: Michael Niedermayer

avcodec/utils: Move avctx->codec check before its use

Fixes CID1361954

Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=b24fffeb9476b46be89229c8df338a8c8f1a9a62
---

 libavcodec/utils.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/libavcodec/utils.c b/libavcodec/utils.c
index e5a832b..11ae4e8 100644
--- a/libavcodec/utils.c
+++ b/libavcodec/utils.c
@@ -2281,6 +2281,9 @@ int attribute_align_arg avcodec_decode_audio4(AVCodecContext *avctx,
 
     *got_frame_ptr = 0;
 
+    if (!avctx->codec)
+        return AVERROR(EINVAL);
+
     if (!avctx->codec->decode) {
         av_log(avctx, AV_LOG_ERROR, "This decoder requires using the avcodec_send_packet() API.\n");
         return AVERROR(ENOSYS);
@@ -2290,8 +2293,6 @@ int attribute_align_arg avcodec_decode_audio4(AVCodecContext *avctx,
         av_log(avctx, AV_LOG_ERROR, "invalid packet: NULL data, size != 0\n");
         return AVERROR(EINVAL);
     }
-    if (!avctx->codec)
-        return AVERROR(EINVAL);
     if (avctx->codec->type != AVMEDIA_TYPE_AUDIO) {
         av_log(avctx, AV_LOG_ERROR, "Invalid media type for audio\n");
         return AVERROR(EINVAL);



More information about the ffmpeg-cvslog mailing list