[FFmpeg-cvslog] icodec: add ico_read_close to fix leaking ico->images

Andreas Cadhalpun git at videolan.org
Sun Nov 27 01:30:10 EET 2016


ffmpeg | branch: release/3.1 | Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com> | Tue Nov  8 23:54:41 2016 +0100| [6a7f0585ab195bb90ed2d3938633c4cd5fe4bc09] | committer: Andreas Cadhalpun

icodec: add ico_read_close to fix leaking ico->images

Reviewed-by: Michael Niedermayer <michael at niedermayer.cc>
Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
(cherry picked from commit d54c95a1435a8a3fcd599108ec85b7f56a0fcbf9)
Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=6a7f0585ab195bb90ed2d3938633c4cd5fe4bc09
---

 libavformat/icodec.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/libavformat/icodec.c b/libavformat/icodec.c
index fa985fb..a0e126a 100644
--- a/libavformat/icodec.c
+++ b/libavformat/icodec.c
@@ -199,6 +199,13 @@ static int read_packet(AVFormatContext *s, AVPacket *pkt)
     return 0;
 }
 
+static int ico_read_close(AVFormatContext * s)
+{
+    IcoDemuxContext *ico = s->priv_data;
+    av_freep(&ico->images);
+    return 0;
+}
+
 AVInputFormat ff_ico_demuxer = {
     .name           = "ico",
     .long_name      = NULL_IF_CONFIG_SMALL("Microsoft Windows ICO"),
@@ -206,5 +213,6 @@ AVInputFormat ff_ico_demuxer = {
     .read_probe     = probe,
     .read_header    = read_header,
     .read_packet    = read_packet,
+    .read_close     = ico_read_close,
     .flags          = AVFMT_NOTIMESTAMPS,
 };



More information about the ffmpeg-cvslog mailing list