[FFmpeg-cvslog] lavc/xface: Reorder conditions to silence a gcc warning.

Carl Eugen Hoyos git at videolan.org
Fri Mar 24 20:53:58 EET 2017


ffmpeg | branch: master | Carl Eugen Hoyos <cehoyos at ag.or.at> | Sun Feb 26 11:03:50 2017 +0100| [66c1c9b2774968dc26017269ac175b356592f878] | committer: Carl Eugen Hoyos

lavc/xface: Reorder conditions to silence a gcc warning.

libavcodec/xface.c:318:27: warning: assuming signed overflow does not occur when assuming that (X - c) > X is always false [-Wstrict-overflow]

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=66c1c9b2774968dc26017269ac175b356592f878
---

 libavcodec/xface.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libavcodec/xface.c b/libavcodec/xface.c
index 8c0cbfd..184c174 100644
--- a/libavcodec/xface.c
+++ b/libavcodec/xface.c
@@ -315,9 +315,9 @@ void ff_xface_generate_face(uint8_t *dst, uint8_t * const src)
 
             for (l = i - 2; l <= i + 2; l++) {
                 for (m = j - 2; m <= j; m++) {
-                    if (l >= i && m == j)
+                    if (l <= 0 || l >= i && m == j)
                         continue;
-                    if (l > 0 && l <= XFACE_WIDTH && m > 0)
+                    if (l <= XFACE_WIDTH && m > 0)
                         k = 2*k + src[l + m * XFACE_WIDTH];
                 }
             }



More information about the ffmpeg-cvslog mailing list