[FFmpeg-cvslog] rtmp: Plug leak if sending bytes read report fails.

Josh Allmann git at videolan.org
Fri Jan 26 00:49:30 EET 2018


ffmpeg | branch: master | Josh Allmann <joshua.allmann at gmail.com> | Tue Jan 23 16:47:12 2018 -0800| [a2a9e4eea0e4fde2ed8d3405b4f33f655b600c2d] | committer: Martin Storsjö

rtmp: Plug leak if sending bytes read report fails.

Signed-off-by: Martin Storsjö <martin at martin.st>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=a2a9e4eea0e4fde2ed8d3405b4f33f655b600c2d
---

 libavformat/rtmpproto.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c
index 115c335974..48c5ead747 100644
--- a/libavformat/rtmpproto.c
+++ b/libavformat/rtmpproto.c
@@ -2396,8 +2396,10 @@ static int get_packet(URLContext *s, int for_header)
         rt->bytes_read += ret;
         if (rt->bytes_read - rt->last_bytes_read > rt->receive_report_size) {
             av_log(s, AV_LOG_DEBUG, "Sending bytes read report\n");
-            if ((ret = gen_bytes_read(s, rt, rpkt.timestamp + 1)) < 0)
+            if ((ret = gen_bytes_read(s, rt, rpkt.timestamp + 1)) < 0) {
+                ff_rtmp_packet_destroy(&rpkt);
                 return ret;
+            }
             rt->last_bytes_read = rt->bytes_read;
         }
 



More information about the ffmpeg-cvslog mailing list