[FFmpeg-cvslog] avformat/aiffenc: Remove wrong and redundant check

Andreas Rheinhardt git at videolan.org
Thu Oct 3 22:34:33 EEST 2019


ffmpeg | branch: master | Andreas Rheinhardt <andreas.rheinhardt at gmail.com> | Wed Oct  2 06:04:12 2019 +0200| [be0d3a2df1a1ec627ba50f535f61f7fcd359f6a4] | committer: Michael Niedermayer

avformat/aiffenc: Remove wrong and redundant check

The check "if (!pb->seekable & AVIO_SEEKABLE_NORMAL)" is wrong, because
! has higher precendence than &. But it is also redundant, because this
part of the code is only ever reached when the AVIO_SEEKABLE_NORMAL flag
is set for pb. So simply remove the check.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
Reviewed-by: Matthieu Bouron <matthieu.bouron at gmail.com>
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=be0d3a2df1a1ec627ba50f535f61f7fcd359f6a4
---

 libavformat/aiffenc.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/libavformat/aiffenc.c b/libavformat/aiffenc.c
index 0b837cd264..d09c9afb95 100644
--- a/libavformat/aiffenc.c
+++ b/libavformat/aiffenc.c
@@ -49,9 +49,6 @@ static int put_id3v2_tags(AVFormatContext *s, AIFFOutputContext *aiff)
     AVIOContext *pb = s->pb;
     AVPacketList *pict_list = aiff->pict_list;
 
-    if (!pb->seekable & AVIO_SEEKABLE_NORMAL)
-        return 0;
-
     if (!s->metadata && !aiff->pict_list)
         return 0;
 



More information about the ffmpeg-cvslog mailing list