[FFmpeg-cvslog] lavf/oggparsevorbis: Use case-insensitive key compare for vorbis picture

Mattias Wadman git at videolan.org
Sat Apr 11 13:57:56 EEST 2020


ffmpeg | branch: master | Mattias Wadman <mattias.wadman at gmail.com> | Sat Apr 11 12:56:21 2020 +0200| [9d21d18ec3ca2721e989fd4522d19bd90d6ac2db] | committer: Carl Eugen Hoyos

lavf/oggparsevorbis: Use case-insensitive key compare for vorbis picture

Regression since 8d3630c5402fdda2889fe4f74f7dcdd50ebca654 where keys were changed
to not be touppered but the picture block strcmp was not changed to be case-insensitive.

Fixes ticket #8608.

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=9d21d18ec3ca2721e989fd4522d19bd90d6ac2db
---

 libavformat/oggparsevorbis.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/oggparsevorbis.c b/libavformat/oggparsevorbis.c
index 8dd27e7770..27d2c686b6 100644
--- a/libavformat/oggparsevorbis.c
+++ b/libavformat/oggparsevorbis.c
@@ -151,7 +151,7 @@ int ff_vorbis_comment(AVFormatContext *as, AVDictionary **m,
              * 'METADATA_BLOCK_PICTURE'. This is the preferred and
              * recommended way of embedding cover art within VorbisComments."
              */
-            if (!strcmp(tt, "METADATA_BLOCK_PICTURE") && parse_picture) {
+            if (!av_strcasecmp(tt, "METADATA_BLOCK_PICTURE") && parse_picture) {
                 int ret, len = AV_BASE64_DECODE_SIZE(vl);
                 char *pict = av_malloc(len);
 



More information about the ffmpeg-cvslog mailing list