[FFmpeg-cvslog] mfenc: Fix building with clang in MSVC mode

Martin Storsjö git at videolan.org
Sat May 23 21:18:22 EEST 2020


ffmpeg | branch: master | Martin Storsjö <martin at martin.st> | Sat May 23 21:14:40 2020 +0300| [2a1fd3c84ef9b5d1daf32fd3cbfebff3c5996ef4] | committer: Martin Storsjö

mfenc: Fix building with clang in MSVC mode

Just including icodecapi.h + codecapi.h apparently misses some bits,
that MSVC doesn't complain about, but Clang does. Thus add a missing
header to the custom hacky include path (required for keeping
ICodecAPI visible when building in UWP mode, as it is intended to).

The issue in Windows SDK headers about ICodecAPI availability in
UWP/app mode has been reported upstream at
https://developercommunity.visualstudio.com/content/problem/1037125/icodecapi-not-visible-when-compiling-in-uwp-mode.html,
and later also filed in Feedback Hub (which can't be linked to
externally).

Signed-off-by: Martin Storsjö <martin at martin.st>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=2a1fd3c84ef9b5d1daf32fd3cbfebff3c5996ef4
---

 libavcodec/mf_utils.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/libavcodec/mf_utils.h b/libavcodec/mf_utils.h
index 39d5844ff6..4373e62ed2 100644
--- a/libavcodec/mf_utils.h
+++ b/libavcodec/mf_utils.h
@@ -28,6 +28,9 @@
 // of including it though, through strmif.h via dshow.h. And on mingw, the
 // mf*.h headers below indirectly include strmif.h.)
 #include <icodecapi.h>
+// Clang in MSVC mode fails on codecapi.h if we haven't included uuids.h
+// before, while it seems to work fine with MSVC itself.
+#include <uuids.h>
 #else
 #include <dshow.h>
 #endif



More information about the ffmpeg-cvslog mailing list