[FFmpeg-cvslog] avcodec/videotoolbox: make FFmpeg-to-VT mapping error more informative

Jan Ekström git at videolan.org
Sat Jan 2 21:02:07 EET 2021


ffmpeg | branch: master | Jan Ekström <jeebjp at gmail.com> | Sat Jan  2 14:30:36 2021 +0200| [ed524136e0d0ae26c9f11df42baf72689499f99f] | committer: Jan Ekström

avcodec/videotoolbox: make FFmpeg-to-VT mapping error more informative

Now logs the actual failed-to-map pixel format as well as range.

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=ed524136e0d0ae26c9f11df42baf72689499f99f
---

 libavcodec/videotoolbox.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/libavcodec/videotoolbox.c b/libavcodec/videotoolbox.c
index 8773de3393..49e726a75f 100644
--- a/libavcodec/videotoolbox.c
+++ b/libavcodec/videotoolbox.c
@@ -1088,7 +1088,13 @@ static int videotoolbox_common_init(AVCodecContext *avctx)
     vtctx->vt_ctx->cv_pix_fmt_type =
         av_map_videotoolbox_format_from_pixfmt2(hw_frames->sw_format, full_range);
     if (!vtctx->vt_ctx->cv_pix_fmt_type) {
-        av_log(avctx, AV_LOG_ERROR, "Unknown sw_format.\n");
+        const AVPixFmtDescriptor *attempted_format =
+            av_pix_fmt_desc_get(hw_frames->sw_format);
+        av_log(avctx, AV_LOG_ERROR,
+               "Failed to map underlying FFmpeg pixel format %s (%s range) to "
+               "a VideoToolbox format!\n",
+               attempted_format ? attempted_format->name : "<unknown>",
+               av_color_range_name(avctx->color_range));
         err = AVERROR(EINVAL);
         goto fail;
     }



More information about the ffmpeg-cvslog mailing list