[FFmpeg-cvslog] avformat/wtvdec: Improve size overflow checks in parse_chunks()
Michael Niedermayer
git at videolan.org
Fri Jun 18 22:13:52 EEST 2021
ffmpeg | branch: release/4.4 | Michael Niedermayer <michael at niedermayer.cc> | Mon Apr 19 20:23:41 2021 +0200| [c1d3a0638afbb73e5f79faf19618691cd70fb0ab] | committer: Michael Niedermayer
avformat/wtvdec: Improve size overflow checks in parse_chunks()
Fixes: signed integer overflow: 32 + 2147483647 cannot be represented in type 'int
Fixes: 32967/clusterfuzz-testcase-minimized-ffmpeg_dem_WTV_fuzzer-5132856218222592
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Reviewed-by: Peter Ross <pross at xvid.org>
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
(cherry picked from commit f8ec1da8ac8e3daf2403e744f166ea9557b2d333)
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=c1d3a0638afbb73e5f79faf19618691cd70fb0ab
---
libavformat/wtvdec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavformat/wtvdec.c b/libavformat/wtvdec.c
index 4b3b7fb407..876256676c 100644
--- a/libavformat/wtvdec.c
+++ b/libavformat/wtvdec.c
@@ -817,7 +817,7 @@ static int parse_chunks(AVFormatContext *s, int mode, int64_t seekts, int *len_p
avio_skip(pb, 12);
ff_get_guid(pb, &formattype);
size = avio_rl32(pb);
- if (size < 0 || size > INT_MAX - 92)
+ if (size < 0 || size > INT_MAX - 92 - consumed)
return AVERROR_INVALIDDATA;
parse_media_type(s, 0, sid, mediatype, subtype, formattype, size);
consumed += 92 + size;
@@ -833,7 +833,7 @@ static int parse_chunks(AVFormatContext *s, int mode, int64_t seekts, int *len_p
avio_skip(pb, 12);
ff_get_guid(pb, &formattype);
size = avio_rl32(pb);
- if (size < 0 || size > INT_MAX - 76)
+ if (size < 0 || size > INT_MAX - 76 - consumed)
return AVERROR_INVALIDDATA;
parse_media_type(s, s->streams[stream_index], sid, mediatype, subtype, formattype, size);
consumed += 76 + size;
More information about the ffmpeg-cvslog
mailing list