[FFmpeg-cvslog] avfilter/vf_uspp: Fix leak of packet side data

Andreas Rheinhardt git at videolan.org
Fri Mar 12 20:27:13 EET 2021


ffmpeg | branch: master | Andreas Rheinhardt <andreas.rheinhardt at gmail.com> | Fri Mar 12 15:07:33 2021 +0100| [6e2db67801c9975fae6f55c40f615d87b9a74a15] | committer: Andreas Rheinhardt

avfilter/vf_uspp: Fix leak of packet side data

The uspp filter uses a special option ("no_bitstream") of
the Snow encoder to suppress it from generating output.
The filter therefore did not unref the packet after usage,
believing it to be blank. But this is wrong, as the Snow encoder
attaches quality stats side data to the packet.

Reviewed-by: Michael Niedermayer <michael at niedermayer.cc>
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=6e2db67801c9975fae6f55c40f615d87b9a74a15
---

 libavfilter/vf_uspp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/libavfilter/vf_uspp.c b/libavfilter/vf_uspp.c
index b77edeb244..523e47c811 100644
--- a/libavfilter/vf_uspp.c
+++ b/libavfilter/vf_uspp.c
@@ -257,6 +257,7 @@ static void filter(USPPContext *p, uint8_t *dst[3], uint8_t *src[3],
             av_log(p->avctx_enc[i], AV_LOG_ERROR, "Encoding failed\n");
             continue;
         }
+        av_packet_unref(&pkt);
 
         p->frame_dec = p->avctx_enc[i]->coded_frame;
 



More information about the ffmpeg-cvslog mailing list