[FFmpeg-cvslog] lavu/tx: remove special -1 inverted lookup mode

Lynne git at videolan.org
Fri Sep 23 13:42:17 EEST 2022


ffmpeg | branch: master | Lynne <dev at lynne.ee> | Fri Sep 23 10:32:39 2022 +0200| [e7a987d7c91e4fb2fc5dd93128d5dee8e2c514f6] | committer: Lynne

lavu/tx: remove special -1 inverted lookup mode

It was somewhat hacky and unnecessary.

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=e7a987d7c91e4fb2fc5dd93128d5dee8e2c514f6
---

 libavutil/tx.c      | 5 +----
 libavutil/tx_priv.h | 3 +--
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/libavutil/tx.c b/libavutil/tx.c
index aeb0d9dada..0c16ecffc3 100644
--- a/libavutil/tx.c
+++ b/libavutil/tx.c
@@ -213,7 +213,7 @@ int ff_tx_gen_split_radix_parity_revtab(AVTXContext *s, int len, int inv,
     if (len < basis)
         return AVERROR(EINVAL);
 
-    if (!(s->map = av_mallocz((inv_lookup == -1 ? 2 : 1)*len*sizeof(*s->map))))
+    if (!(s->map = av_mallocz(len*sizeof(*s->map))))
         return AVERROR(ENOMEM);
 
     av_assert0(!dual_stride || !(dual_stride & (dual_stride - 1)));
@@ -221,9 +221,6 @@ int ff_tx_gen_split_radix_parity_revtab(AVTXContext *s, int len, int inv,
 
     parity_revtab_generator(s->map, len, inv, 0, 0, 0, len,
                             basis, dual_stride, inv_lookup != 0);
-    if (inv_lookup == -1)
-        parity_revtab_generator(s->map + len, len, inv, 0, 0, 0, len,
-                                basis, dual_stride, 0);
 
     return 0;
 }
diff --git a/libavutil/tx_priv.h b/libavutil/tx_priv.h
index 28ac31a597..3195cb51b2 100644
--- a/libavutil/tx_priv.h
+++ b/libavutil/tx_priv.h
@@ -290,8 +290,7 @@ int ff_tx_gen_ptwo_inplace_revtab_idx(AVTXContext *s);
  * If length is smaller than basis/2 this function will not do anything.
  *
  * If inv_lookup is set to 1, it will flip the lookup from out[map[i]] = src[i]
- * to out[i] = src[map[i]]. If set to -1, will generate 2 maps, the first one
- * flipped, the second one regular.
+ * to out[i] = src[map[i]].
  */
 int ff_tx_gen_split_radix_parity_revtab(AVTXContext *s, int len, int inv,
                                         int inv_lookup, int basis, int dual_stride);



More information about the ffmpeg-cvslog mailing list