[FFmpeg-cvslog] libavformat/riffec: Zero-initialize channels in ff_get_wav_header

Will Cassella git at videolan.org
Sat Aug 12 19:26:22 EEST 2023


ffmpeg | branch: release/5.1 | Will Cassella <cassew at chromium.org> | Fri Sep  9 22:50:32 2022 +0000| [566aa38d98f5f492995127e82ab9a516f59bf952] | committer: James Almer

libavformat/riffec: Zero-initialize channels in ff_get_wav_header

Clang's static analyzer complains that leaving the  variable
uninitialized could lead to a code path where the uninitialized value is
written to  at the end of this function.
This patch simply zero-initializes that variable to avoid that.

Signed-off-by: Will Cassella <cassew at google.com>
Signed-off-by: James Almer <jamrial at gmail.com>
(cherry picked from commit e601ec3c1991ee09ff45db3be4d894e5774f6f2b)

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=566aa38d98f5f492995127e82ab9a516f59bf952
---

 libavformat/riffdec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/riffdec.c b/libavformat/riffdec.c
index c1e4a04550..1c149388ab 100644
--- a/libavformat/riffdec.c
+++ b/libavformat/riffdec.c
@@ -94,7 +94,7 @@ static void parse_waveformatex(AVFormatContext *s, AVIOContext *pb, AVCodecParam
 int ff_get_wav_header(AVFormatContext *s, AVIOContext *pb,
                       AVCodecParameters *par, int size, int big_endian)
 {
-    int id, channels;
+    int id, channels = 0;
     uint64_t bitrate = 0;
 
     if (size < 14) {



More information about the ffmpeg-cvslog mailing list