[FFmpeg-cvslog] avcodec/jpegxl_parser: Add padding to cs_buffer
Michael Niedermayer
git at videolan.org
Fri Dec 29 03:11:15 EET 2023
ffmpeg | branch: master | Michael Niedermayer <michael at niedermayer.cc> | Fri Dec 15 02:07:56 2023 +0100| [5f88458bea698e00913a38940a7c34994151d2a8] | committer: Michael Niedermayer
avcodec/jpegxl_parser: Add padding to cs_buffer
Fixes: out of array access
Fixes: 64081/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-6151006496620544
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=5f88458bea698e00913a38940a7c34994151d2a8
---
libavcodec/jpegxl_parser.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/libavcodec/jpegxl_parser.c b/libavcodec/jpegxl_parser.c
index f87ec6d35a..ceb6191c95 100644
--- a/libavcodec/jpegxl_parser.c
+++ b/libavcodec/jpegxl_parser.c
@@ -162,7 +162,7 @@ typedef struct JXLParseContext {
int skipped_icc;
int next;
- uint8_t cs_buffer[4096];
+ uint8_t cs_buffer[4096 + AV_INPUT_BUFFER_PADDING_SIZE];
} JXLParseContext;
/* used for reading brotli prefixes */
@@ -1401,7 +1401,7 @@ static int try_parse(AVCodecParserContext *s, AVCodecContext *avctx, JXLParseCon
if (ctx->container || AV_RL64(buf) == FF_JPEGXL_CONTAINER_SIGNATURE_LE) {
ctx->container = 1;
ret = ff_jpegxl_collect_codestream_header(buf, buf_size, ctx->cs_buffer,
- sizeof(ctx->cs_buffer), &ctx->copied);
+ sizeof(ctx->cs_buffer) - AV_INPUT_BUFFER_PADDING_SIZE, &ctx->copied);
if (ret < 0)
return ret;
ctx->collected_size = ret;
@@ -1410,7 +1410,7 @@ static int try_parse(AVCodecParserContext *s, AVCodecContext *avctx, JXLParseCon
return AVERROR_BUFFER_TOO_SMALL;
}
cs_buffer = ctx->cs_buffer;
- cs_buflen = FFMIN(sizeof(ctx->cs_buffer), ctx->copied);
+ cs_buflen = FFMIN(sizeof(ctx->cs_buffer) - AV_INPUT_BUFFER_PADDING_SIZE, ctx->copied);
} else {
cs_buffer = buf;
cs_buflen = buf_size;
More information about the ffmpeg-cvslog
mailing list