[FFmpeg-cvslog] fftools/ffmpeg_filter: don't clear buffersrc params

Niklas Haas git at videolan.org
Sun Dec 31 23:49:41 EET 2023


ffmpeg | branch: master | Niklas Haas <git at haasn.dev> | Sat Oct 28 14:45:18 2023 +0200| [9d0f361f7fb84392d8ea032e954f7323c48404b1] | committer: Niklas Haas

fftools/ffmpeg_filter: don't clear buffersrc params

This memset is bogus, it accomplishes nothing in the best case and
regresses future additions to AVBufferSrcParameters in the worst case.

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=9d0f361f7fb84392d8ea032e954f7323c48404b1
---

 fftools/ffmpeg_filter.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c
index c1c3014453..3383f5a40a 100644
--- a/fftools/ffmpeg_filter.c
+++ b/fftools/ffmpeg_filter.c
@@ -1465,11 +1465,8 @@ static int configure_input_video_filter(FilterGraph *fg, AVFilterGraph *graph,
     int ret, pad_idx = 0;
     int64_t tsoffset = 0;
     AVBufferSrcParameters *par = av_buffersrc_parameters_alloc();
-
     if (!par)
         return AVERROR(ENOMEM);
-    memset(par, 0, sizeof(*par));
-    par->format = AV_PIX_FMT_NONE;
 
     if (ist->dec_ctx->codec_type == AVMEDIA_TYPE_AUDIO) {
         av_log(fg, AV_LOG_ERROR, "Cannot connect video filter to audio input\n");



More information about the ffmpeg-cvslog mailing list