[FFmpeg-cvslog] lavfi/buffersrc: issue more specific error in case of invalid parameters

Stefano Sabatini git at videolan.org
Sun Mar 5 13:38:33 EET 2023


ffmpeg | branch: master | Stefano Sabatini <stefasab at gmail.com> | Wed Mar  1 01:00:17 2023 +0100| [ad17e2922482fd34b056d87e46097abb2c4996ce] | committer: Stefano Sabatini

lavfi/buffersrc: issue more specific error in case of invalid parameters

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=ad17e2922482fd34b056d87e46097abb2c4996ce
---

 libavfilter/buffersrc.c | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/libavfilter/buffersrc.c b/libavfilter/buffersrc.c
index ba17450b93..a1740da054 100644
--- a/libavfilter/buffersrc.c
+++ b/libavfilter/buffersrc.c
@@ -273,9 +273,16 @@ static av_cold int init_video(AVFilterContext *ctx)
 {
     BufferSourceContext *c = ctx->priv;
 
-    if (c->pix_fmt == AV_PIX_FMT_NONE || !c->w || !c->h ||
-        av_q2d(c->time_base) <= 0) {
-        av_log(ctx, AV_LOG_ERROR, "Invalid parameters provided.\n");
+    if (c->pix_fmt == AV_PIX_FMT_NONE) {
+        av_log(ctx, AV_LOG_ERROR, "Unspecified pixel format\n");
+        return AVERROR(EINVAL);
+    }
+    if (c->w <= 0 || c->h <= 0) {
+        av_log(ctx, AV_LOG_ERROR, "Invalid size %dx%d\n", c->w, c->h);
+        return AVERROR(EINVAL);
+    }
+    if (av_q2d(c->time_base) <= 0) {
+        av_log(ctx, AV_LOG_ERROR, "Invalid time base %d/%d\n", c->time_base.num, c->time_base.den);
         return AVERROR(EINVAL);
     }
 



More information about the ffmpeg-cvslog mailing list