[FFmpeg-cvslog] avfilter/avf_showvolume: improve step for vertical orientation

Paul B Mahol git at videolan.org
Sun Nov 19 00:44:16 EET 2023


ffmpeg | branch: master | Paul B Mahol <onemda at gmail.com> | Sat Nov 18 23:44:18 2023 +0100| [7c16bf0829802534004326c8e65fb6cdbdb634fa] | committer: Paul B Mahol

avfilter/avf_showvolume: improve step for vertical orientation

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=7c16bf0829802534004326c8e65fb6cdbdb634fa
---

 libavfilter/avf_showvolume.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/libavfilter/avf_showvolume.c b/libavfilter/avf_showvolume.c
index b61f6c1d4f..7ec9daf628 100644
--- a/libavfilter/avf_showvolume.c
+++ b/libavfilter/avf_showvolume.c
@@ -370,13 +370,13 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *insamples)
             max = av_clipf(max, 0, 1);
             max_draw = calc_max_draw(s, outlink, max);
 
-            for (j = max_draw; j < s->w; j++) {
+            for (j = s->w - 1; j >= max_draw; j--) {
                 uint8_t *dst = s->out->data[0] + j * s->out->linesize[0] + c * (s->b + s->h) * 4;
                 for (k = 0; k < s->h; k++) {
                     AV_WN32A(&dst[k * 4], lut[s->w - j - 1]);
-                    if (j & step)
-                        j += step;
                 }
+                if (j & step)
+                    j -= step;
             }
 
             if (s->draw_persistent_duration > 0.) {



More information about the ffmpeg-cvslog mailing list