[FFmpeg-cvslog] libavcodec/lcldec: width and height should not be unsigned

Michael Niedermayer git at videolan.org
Thu Oct 19 14:31:19 EEST 2023


ffmpeg | branch: release/2.8 | Michael Niedermayer <michael at niedermayer.cc> | Thu Mar  9 13:57:14 2023 +0100| [e9fbbed49ef44a024e99b975bd2688da3633575c] | committer: Michael Niedermayer

libavcodec/lcldec: width and height should not be unsigned

Computations like col < width - 3 will not work with unsigned width=1

Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
(cherry picked from commit 3eb4e28c26c3bce608214f392ab1fe6ee28ec1df)
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=e9fbbed49ef44a024e99b975bd2688da3633575c
---

 libavcodec/lcldec.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libavcodec/lcldec.c b/libavcodec/lcldec.c
index c04ed5e6ca..0b7f5df045 100644
--- a/libavcodec/lcldec.c
+++ b/libavcodec/lcldec.c
@@ -173,8 +173,8 @@ static int decode_frame(AVCodecContext *avctx, void *data, int *got_frame, AVPac
     int row, col;
     unsigned char *encoded = avpkt->data, *outptr;
     uint8_t *y_out, *u_out, *v_out;
-    unsigned int width = avctx->width; // Real image width
-    unsigned int height = avctx->height; // Real image height
+    int width = avctx->width; // Real image width
+    int height = avctx->height; // Real image height
     unsigned int mszh_dlen;
     unsigned char yq, y1q, uq, vq;
     int uqvq, ret;



More information about the ffmpeg-cvslog mailing list