[FFmpeg-cvslog] avutil/softfloat: fix av_sincos_sf()

Michael Niedermayer git at videolan.org
Thu Oct 19 14:31:42 EEST 2023


ffmpeg | branch: release/2.8 | Michael Niedermayer <michael at niedermayer.cc> | Tue Jun 20 00:59:40 2023 +0200| [65312adc4161c091e424fed4d308cb0fb2cef1af] | committer: Michael Niedermayer

avutil/softfloat: fix av_sincos_sf()

Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
(cherry picked from commit d84677abd8ffb8ca8ad94eced6d9e03928f35d79)
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=65312adc4161c091e424fed4d308cb0fb2cef1af
---

 libavutil/softfloat.c | 2 +-
 libavutil/softfloat.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/libavutil/softfloat.c b/libavutil/softfloat.c
index 4bfbbb26af..0e3a334178 100644
--- a/libavutil/softfloat.c
+++ b/libavutil/softfloat.c
@@ -146,7 +146,7 @@ int main(void){
         av_sincos_sf(i*(1ULL<<32)/36/4, &s, &c);
         errs = (double)s/ (1<<30) - sin(i*M_PI/36);
         errc = (double)c/ (1<<30) - cos(i*M_PI/36);
-        if (fabs(errs) > 0.00000002 || fabs(errc) >0.001) {
+        if (fabs(errs) > 0.000000004 || fabs(errc) >0.000000004) {
             printf("sincos FAIL %d %f %f %f %f\n", i, (float)s/ (1<<30), (float)c/ (1<<30), sin(i*M_PI/36), cos(i*M_PI/36));
         }
 
diff --git a/libavutil/softfloat.h b/libavutil/softfloat.h
index b7340577bc..ed099456c2 100644
--- a/libavutil/softfloat.h
+++ b/libavutil/softfloat.h
@@ -260,7 +260,7 @@ static av_unused void av_sincos_sf(int a, int *s, int *c)
                 (int64_t)av_sintbl_4_sf[(idx & 0x1f) + 1] * (a & 0x7ff) +
                 0x400) >> 11);
 
-    *c = (int)(((int64_t)cv * ct + (int64_t)sv * st + 0x20000000) >> 30);
+    *c = (int)(((int64_t)cv * ct - (int64_t)sv * st + 0x20000000) >> 30);
 
     *s = (int)(((int64_t)cv * st + (int64_t)sv * ct + 0x20000000) >> 30);
 }



More information about the ffmpeg-cvslog mailing list