[FFmpeg-cvslog] lavu/tx: fix scaling of R2R transforms

Lynne git at videolan.org
Sat Sep 2 01:00:22 EEST 2023


ffmpeg | branch: master | Lynne <dev at lynne.ee> | Fri Sep  1 06:13:51 2023 +0200| [d40672e661037c770f50e45c8c09f523ed9a77d0] | committer: Lynne

lavu/tx: fix scaling of R2R transforms

Still slightly inaccurate, but it's good enough now.

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=d40672e661037c770f50e45c8c09f523ed9a77d0
---

 libavutil/tx_template.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/libavutil/tx_template.c b/libavutil/tx_template.c
index 4745b56700..6e3b3dad33 100644
--- a/libavutil/tx_template.c
+++ b/libavutil/tx_template.c
@@ -1613,6 +1613,7 @@ static av_cold int TX_NAME(ff_tx_rdft_init)(AVTXContext *s,
     int ret;
     double f, m;
     TXSample *tab;
+    uint64_t r2r = flags & AV_TX_REAL_TO_REAL;
     int len4 = FFALIGN(len, 4) / 4;
 
     s->scale_d = *((SCALE_TYPE *)scale);
@@ -1638,7 +1639,10 @@ static av_cold int TX_NAME(ff_tx_rdft_init)(AVTXContext *s,
     *tab++ = RESCALE(-m);
 
     *tab++ = RESCALE( (0.5 - 0.0) * m);
-    *tab++ = RESCALE( (0.0 - 0.5) * m);
+    if (r2r)
+        *tab++ = 1 / s->scale_f;
+    else
+        *tab++ = RESCALE( (0.0 - 0.5) * m);
     *tab++ = RESCALE( (0.5 - inv) * m);
     *tab++ = RESCALE(-(0.5 - inv) * m);
 
@@ -1804,7 +1808,7 @@ static void TX_NAME(ff_tx_rdft_ ##n)(AVTXContext *s, void *_dst,               \
     if (mode == AV_TX_REAL_TO_REAL) {                                          \
         out[len2] = tmp_dc;                                                    \
         if (mod2)                                                              \
-            out[len4 + 1] = tmp_mid;                                           \
+            out[len4 + 1] = tmp_mid * fact[5];                                 \
     } else if (mod2) {                                                         \
         out[len4] = tmp_mid;                                                   \
     }                                                                          \



More information about the ffmpeg-cvslog mailing list