[FFmpeg-cvslog] vvcdec: add TODO for combining transform, lmcs_scale_chroma, and add_residual

Nuo Mi git at videolan.org
Sun Jan 7 03:05:59 EET 2024


ffmpeg | branch: master | Nuo Mi <nuomi2021 at gmail.com> | Wed Jan  3 23:52:52 2024 +0800| [02d600c568d14a201c776712bc5775e17c59078a] | committer: Nuo Mi

vvcdec: add TODO for combining transform, lmcs_scale_chroma, and add_residual

Thanks for the suggestion from Lynne.

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=02d600c568d14a201c776712bc5775e17c59078a
---

 libavcodec/vvc/vvc_intra.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libavcodec/vvc/vvc_intra.c b/libavcodec/vvc/vvc_intra.c
index 43de312a71..214ad38c8c 100644
--- a/libavcodec/vvc/vvc_intra.c
+++ b/libavcodec/vvc/vvc_intra.c
@@ -552,6 +552,8 @@ static void itransform(VVCLocalContext *lc, TransformUnit *tu, const int tu_idx,
 
             if (chroma_scale)
                 fc->vvcdsp.intra.lmcs_scale_chroma(lc, temp, tb->coeffs, w, h, cu->x0, cu->y0);
+            // TODO: Address performance issue here by combining transform, lmcs_scale_chroma, and add_residual into one function.
+            // Complete this task before implementing ASM code.
             fc->vvcdsp.itx.add_residual(dst, chroma_scale ? temp : tb->coeffs, w, h, stride);
 
             if (tu->joint_cbcr_residual_flag && tb->c_idx)



More information about the ffmpeg-cvslog mailing list