[FFmpeg-cvslog] avformat/rtsp: initialize reply1

Michael Niedermayer git at videolan.org
Mon Jul 8 00:40:01 EEST 2024


ffmpeg | branch: master | Michael Niedermayer <michael at niedermayer.cc> | Sat Jun  8 18:28:49 2024 +0200| [498ce4e8b82e2312690613df45f87e592dcb91a9] | committer: Michael Niedermayer

avformat/rtsp: initialize reply1

It seems reply1 is initialized by ff_rtsp_send_cmd() in most cases but there
are code paths like "continue" which look like they could skip it but even if not
writing this so a complex loop after several layers of calls initialized a local
variable through a pointer is just bad design.
This patch simply initialized the variable.

Fixes: CID1473532 Uninitialized scalar variable

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=498ce4e8b82e2312690613df45f87e592dcb91a9
---

 libavformat/rtsp.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c
index 28c858077a..c6fca89d83 100644
--- a/libavformat/rtsp.c
+++ b/libavformat/rtsp.c
@@ -1462,6 +1462,8 @@ int ff_rtsp_make_setup_request(AVFormatContext *s, const char *host, int port,
     char cmd[MAX_URL_SIZE];
     const char *trans_pref;
 
+    memset(&reply1, 0, sizeof(reply1));
+
     if (rt->transport == RTSP_TRANSPORT_RDT)
         trans_pref = "x-pn-tng";
     else if (rt->transport == RTSP_TRANSPORT_RAW)



More information about the ffmpeg-cvslog mailing list