[FFmpeg-cvslog] avcodec/osq: fix integer overflow when applying factor

Michael Niedermayer git at videolan.org
Wed Jul 24 00:24:28 EEST 2024


ffmpeg | branch: master | Michael Niedermayer <michael at niedermayer.cc> | Fri Sep 15 00:49:41 2023 +0200| [6420c1bf30884d5feb69d0a6f116eaceac02dacc] | committer: Michael Niedermayer

avcodec/osq: fix integer overflow when applying factor

Fixes: signed integer overflow: -35511773 * 256 cannot be represented in type 'int'
Fixes: 70406/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_OSQ_fuzzer-6545326804434944

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=6420c1bf30884d5feb69d0a6f116eaceac02dacc
---

 libavcodec/osq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/osq.c b/libavcodec/osq.c
index 42a46b25ce..4e921896c0 100644
--- a/libavcodec/osq.c
+++ b/libavcodec/osq.c
@@ -356,7 +356,7 @@ static int osq_decode_block(AVCodecContext *avctx, AVFrame *frame)
     const int nb_channels = avctx->ch_layout.nb_channels;
     const int nb_samples = frame->nb_samples;
     OSQContext *s = avctx->priv_data;
-    const int factor = s->factor;
+    const unsigned factor = s->factor;
     int ret, decorrelate, downsample;
     GetBitContext *gb = &s->gb;
 



More information about the ffmpeg-cvslog mailing list