[FFmpeg-cvslog] [ffmpeg-fateserver] branch master updated. bdfef11 Properly list test errors when there are no failed tests

ffmpeg-git at ffmpeg.org ffmpeg-git at ffmpeg.org
Sat Jun 28 11:35:43 EEST 2025


The branch, master has been updated
       via  bdfef11e4826e703ec0638c8093dbd3cfcbec958 (commit)
      from  fd02ae530d5fa5b71987a47125ff308633e98b76 (commit)


- Log -----------------------------------------------------------------
commit bdfef11e4826e703ec0638c8093dbd3cfcbec958
Author:     Martin Storsjö <martin at martin.st>
AuthorDate: Fri May 16 11:07:16 2025 +0300
Commit:     Martin Storsjö <martin at martin.st>
CommitDate: Sat Jun 28 11:34:55 2025 +0300

    Properly list test errors when there are no failed tests
    
    If there were failures while running tests, e.g. if failing to
    compile checkasm or any other of the test programs, there are no
    failed tests per se, and the number of succeessful tests is
    equal to the total number of tests.
    
    For these cases, check the job status code instead of declaring
    them as a full success.

diff --git a/history.cgi b/history.cgi
index e38672f..5e4f007 100755
--- a/history.cgi
+++ b/history.cgi
@@ -76,7 +76,7 @@ for my $date ((sort { $b cmp $a } @reps)[0..49]) {
     td $$rep{nwarn};
     if ($npass) {
         $rtext  = "$npass / $ntest";
-        $rclass = $npass==$ntest? 'pass' : $npass? 'warn' : 'fail';
+        $rclass = $$rep{status}==0? 'pass' : $npass? 'warn' : 'fail';
     } elsif (!$ntest and !$$rep{status}) {
         $rtext  = "build only";
         $rclass = $$rep{status}? 'fail' : 'pass';
diff --git a/index.cgi b/index.cgi
index c053d0e..e0d7da0 100755
--- a/index.cgi
+++ b/index.cgi
@@ -286,7 +286,7 @@ for my $rep (sort repcmp @reps) {
     td $$rep{comment}, class => 'comment';
     if ($npass) {
         $rtext  = "$npass / $ntest";
-        $rclass = $npass==$ntest? 'pass' : $npass? 'warn' : 'fail';
+        $rclass = $$rep{status}==0? 'pass' : $npass? 'warn' : 'fail';
     } elsif (!$ntest and !$$rep{status}) {
         $rtext  = "build only";
         $rclass = $$rep{status}? 'fail' : 'pass';
diff --git a/report.cgi b/report.cgi
index fb00fee..c9ffae5 100755
--- a/report.cgi
+++ b/report.cgi
@@ -183,7 +183,11 @@ if ($nfail) {
     }
     end 'tbody';
 } elsif ($ntest) {
-    start 'tr', class => 'pass'; th 'All tests successful', colspan => 3; end;
+    if ($$hdr{status}) {
+        start 'tr', class => 'fail'; th 'Failure building tests', colspan => 3; end;
+    } else {
+        start 'tr', class => 'pass'; th 'All tests successful', colspan => 3; end;
+    }
 } else {
     my $class = $$hdr{status}? 'fail' : 'pass';
     start 'tr', class => $class; th 'No tests were run',    colspan => 3; end;

-----------------------------------------------------------------------

Summary of changes:
 history.cgi | 2 +-
 index.cgi   | 2 +-
 report.cgi  | 6 +++++-
 3 files changed, 7 insertions(+), 3 deletions(-)


hooks/post-receive
-- 



More information about the ffmpeg-cvslog mailing list