[FFmpeg-cvslog] avcodec/sonic: Check num_taps
Michael Niedermayer
git at videolan.org
Fri May 16 20:59:42 EEST 2025
ffmpeg | branch: release/4.2 | Michael Niedermayer <michael at niedermayer.cc> | Sun May 11 01:08:06 2025 +0200| [abd06f81c89a693000c241e1a5955962fcb25741] | committer: Michael Niedermayer
avcodec/sonic: Check num_taps
The encoder uses max 128 taps, which is quiet a lot already
If work is done to improve sonic, it will be more radical than changing the taps
Fixes: Timeout
Fixes: 402539974/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SONIC_fuzzer-6122944271286272
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
(cherry picked from commit fd0a792766c8ae513dd849fc47fa9e899cc5664b)
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=abd06f81c89a693000c241e1a5955962fcb25741
---
libavcodec/sonic.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/libavcodec/sonic.c b/libavcodec/sonic.c
index b6bb1c3a84..b0746002d4 100644
--- a/libavcodec/sonic.c
+++ b/libavcodec/sonic.c
@@ -927,6 +927,9 @@ static av_cold int sonic_decode_init(AVCodecContext *avctx)
if (get_bits1(&gb)) // XXX FIXME
av_log(avctx, AV_LOG_INFO, "Custom quant table\n");
+ if (s->num_taps > 128)
+ return AVERROR_INVALIDDATA;
+
s->block_align = 2048LL*s->samplerate/(44100*s->downsampling);
s->frame_size = s->channels*s->block_align*s->downsampling;
// avctx->frame_size = s->block_align;
More information about the ffmpeg-cvslog
mailing list